Feat #246 - Provider function to query for UTxOs at an address with an asset #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Micrograx
approved these changes
Oct 26, 2023
There was a problem hiding this comment.
As discussed during the standup, maybe we could leave utxosAtAddress the way it was, and add a new endpoint like utxosAtAddressWithAsset that has the extra Maybe GYAssetClass parameter. Normal utxosAtAddress could just call utxosAtAddressWithAsset with a default Nothing value for asset.
But this current solution doesn't bother me much as well. Up to you if you want to update it or merge it as is.
|
@Micrograx I was thinking to implement this suggestion but seeing that we are already using commit of this PR and that there is a overhaul of types (so that there are no thunks) coming, I am inclined to merging it as it is. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.