Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update translations for Portuguese in codelists for schema 19139 #8521

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

julianofinck
Copy link

@julianofinck julianofinck commented Nov 28, 2024

In the Portuguese codelist for the schema 19139, few words had typos and others were in Spanish.

Checklist

  • I have read the contribution guidelines
  • Pull request provided for main branch, backports managed with label
  • Good housekeeping of code, cleaning up comments, tests, and documentation
  • Clean commit history broken into understandable chucks, avoiding big commits with hundreds of files, cautious of reformatting and whitespace changes
  • Clean commit messages, longer verbose messages are encouraged
  • API Changes are identified in commit messages
  • Testing provided for features or enhancements using automatic tests
  • User documentation provided for new features or enhancements in manual
  • Build documentation provided for development instructions in README.md files
  • Library management using pom.xml dependency management. Update build documentation with intended library use and library tutorials or documentation

@julianofinck
Copy link
Author

If this PR gets accepted, does it also gets applied to the 3.10.X branch that had the last commit 2 years ago, or we do not perform backward adjustments?

@josegar74
Copy link
Member

@julianofinck The encoding of the file you committed in the pull request doesn't look fine:

https://github.com/geonetwork/core-geonetwork/pull/8521/files#diff-06541c6e9fe74ce5a701c20deac7c4577b54e9f7e1d7d187f2a4b138429bb1c9R89

Compare to the original file:

<description>Visualização digital dum item principalmente escrito (também possa conter

@julianofinck julianofinck force-pushed the translations-update-por-iso19139 branch from c6be92a to ea503b4 Compare December 1, 2024 15:33
@julianofinck
Copy link
Author

@josegar74, thank you very much for your feedback!

I believe you meant the encoding "ISO-8859-1" was not fine, although the ISO19139 Portuguese's codelist.xml was in this encoding from the start: codelist.xml

After inspection, I realized all other languages had this file in "UTF-8". I thus re-saved it with the encoding "UTF-8" (and changed the XML header as well).

Presumably the encoding is fine right now. If not, do not hesitate to tell me.
PS: I had to force-push because had pushed many commits before that looked ugly. I squashed them in a more logical way.

@CLAassistant
Copy link

CLAassistant commented Dec 8, 2024

CLA assistant check
All committers have signed the CLA.

@julianofinck
Copy link
Author

julianofinck commented Dec 8, 2024

The link to sign the CLA is returning 500 with message:
Error - There is no CLA to sign for geonetwork/core-geonetwork
(could not find linked item for owner geonetwork and repo core-geonetwork)

Must it be issued again, @josegar74?

@josegar74
Copy link
Member

@julianofinck I don't know about this new CLA stuff.

I'll check the updated changes this week and merge them.

@josegar74 josegar74 added this to the 4.4.7 milestone Dec 11, 2024
@josegar74
Copy link
Member

@julianofinck the pull request works fine. I found a problem in the codelist.xml not related to your changes, but it would be nice to fix it.

In the add online resources the function list doesn't show values in Portuguese:

online-resource-function

The following line:

<codelist name="gmd:CI_OnLineFunctionCode">

Needs to be updated to

<codelist name="gmd:CI_OnLineFunctionCode" alias="function">

Can you update the pull request with this change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants