-
-
Notifications
You must be signed in to change notification settings - Fork 490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update translations for Portuguese in codelists for schema 19139 #8521
base: main
Are you sure you want to change the base?
Update translations for Portuguese in codelists for schema 19139 #8521
Conversation
If this PR gets accepted, does it also gets applied to the 3.10.X branch that had the last commit 2 years ago, or we do not perform backward adjustments? |
@julianofinck The encoding of the file you committed in the pull request doesn't look fine: Compare to the original file:
|
…1 to UTF-8 just like other languages
c6be92a
to
ea503b4
Compare
@josegar74, thank you very much for your feedback! I believe you meant the encoding "ISO-8859-1" was not fine, although the ISO19139 Portuguese's codelist.xml was in this encoding from the start: codelist.xml After inspection, I realized all other languages had this file in "UTF-8". I thus re-saved it with the encoding "UTF-8" (and changed the XML header as well). Presumably the encoding is fine right now. If not, do not hesitate to tell me. |
The link to sign the CLA is returning 500 with message: Must it be issued again, @josegar74? |
@julianofinck I don't know about this new CLA stuff. I'll check the updated changes this week and merge them. |
@julianofinck the pull request works fine. I found a problem in the In the add online resources the function list doesn't show values in Portuguese: The following line: <codelist name="gmd:CI_OnLineFunctionCode"> Needs to be updated to <codelist name="gmd:CI_OnLineFunctionCode" alias="function"> Can you update the pull request with this change? |
In the Portuguese codelist for the schema 19139, few words had typos and others were in Spanish.
Checklist
main
branch, backports managed with labelREADME.md
filespom.xml
dependency management. Update build documentation with intended library use and library tutorials or documentation