-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature - Add serverless tasks and spend #37
Conversation
whoops! will add mock_data |
This is actually in our warehouse (too big for seeds!) - but if you’re able to provide a sample I can add it for the tests? |
thanks for the contribution @GtheSheep ! much appreciated.
@GtheSheep which categories are you seeing the discrepancies in? There's the rounding issues mentioned in #25, then we've also seen storage not match up perfectly on 1/5 accounts we've validated against. |
Hey @ian-whitestone - anytime! In the grand scheme of things, not major. I could probably check the compute units to see if they match up just in case |
This is ready to ship @GtheSheep - would you mind adding a changelog entry? Instructions here. We can add sample data at a later point, the logic looks sound. |
@NiallRees All done, will send some sample data over later 👌 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙌
Closes #36
This is very close to matching the invoice I received from Snowflake today, there are slight discrepancies in other spends generated by this package and my final bill though which there seems to be an issue related to?
Let me know if there's other models this should be included in also