Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature - Add serverless tasks and spend #37

Merged
merged 5 commits into from
Dec 6, 2022

Conversation

GtheSheep
Copy link
Contributor

Closes #36

This is very close to matching the invoice I received from Snowflake today, there are slight discrepancies in other spends generated by this package and my final bill though which there seems to be an issue related to?

Let me know if there's other models this should be included in also

@GtheSheep GtheSheep temporarily deployed to Approve Integration Tests December 6, 2022 14:01 Inactive
@GtheSheep GtheSheep had a problem deploying to Approve Integration Tests December 6, 2022 14:01 Failure
@GtheSheep
Copy link
Contributor Author

whoops! will add mock_data

@NiallRees
Copy link
Member

NiallRees commented Dec 6, 2022

whoops! will add mock_data

This is actually in our warehouse (too big for seeds!) - but if you’re able to provide a sample I can add it for the tests?

@ian-whitestone
Copy link
Contributor

ian-whitestone commented Dec 6, 2022

thanks for the contribution @GtheSheep ! much appreciated.

there are slight discrepancies in other spends generated by this package and my final bill though which there seems to be an issue related to?

@GtheSheep which categories are you seeing the discrepancies in?

There's the rounding issues mentioned in #25, then we've also seen storage not match up perfectly on 1/5 accounts we've validated against.

@GtheSheep GtheSheep had a problem deploying to Approve Integration Tests December 6, 2022 15:51 Failure
@GtheSheep GtheSheep temporarily deployed to Approve Integration Tests December 6, 2022 15:51 Inactive
@NiallRees NiallRees temporarily deployed to Approve Integration Tests December 6, 2022 15:55 Inactive
@NiallRees NiallRees temporarily deployed to Approve Integration Tests December 6, 2022 15:55 Inactive
@GtheSheep GtheSheep temporarily deployed to Approve Integration Tests December 6, 2022 16:06 Inactive
@GtheSheep GtheSheep temporarily deployed to Approve Integration Tests December 6, 2022 16:06 Inactive
@GtheSheep
Copy link
Contributor Author

Hey @ian-whitestone - anytime!
The for some categories, such as Cloud Services, Adjustments, the difference is like ~$1 on a few hundred so may be related to that.
The bigger differences are from Storage ~$10 on a couple hundred spend, and Compute ~$30 on a ~$10k spend.

In the grand scheme of things, not major. I could probably check the compute units to see if they match up just in case

@NiallRees
Copy link
Member

NiallRees commented Dec 6, 2022

This is ready to ship @GtheSheep - would you mind adding a changelog entry? Instructions here. We can add sample data at a later point, the logic looks sound.

@GtheSheep GtheSheep had a problem deploying to Approve Integration Tests December 6, 2022 16:33 Failure
@GtheSheep GtheSheep had a problem deploying to Approve Integration Tests December 6, 2022 16:33 Failure
@GtheSheep
Copy link
Contributor Author

@NiallRees All done, will send some sample data over later 👌

Copy link
Member

@NiallRees NiallRees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@NiallRees NiallRees merged commit f9523e8 into get-select:main Dec 6, 2022
@GtheSheep GtheSheep deleted the feature/serverless-tasks branch December 6, 2022 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Model the Serverless Task history
3 participants