Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace delete-cache --sizes by show-cache #85

Merged
merged 1 commit into from
Sep 18, 2024
Merged

Replace delete-cache --sizes by show-cache #85

merged 1 commit into from
Sep 18, 2024

Conversation

silkeh
Copy link
Member

@silkeh silkeh commented Mar 4, 2024

The --sizes flag for delete-cache is confusing as it makes the command not actually delete sizes.

Deprecate the confusing flag, and add a new command to replace it: show-cache.

Resolves #80

@silkeh silkeh added the enhancement New feature or request label Mar 4, 2024
@silkeh silkeh added this to the 1.7.0 milestone Mar 4, 2024
The `--sizes` flag for `delete-cache` is confusing as it makes the command
not actually delete sizes.

Deprecate the confusing flag, and add a new command to replace it: `show-cache`.
@silkeh silkeh marked this pull request as ready for review September 18, 2024 15:58
Copy link
Contributor

@ermo ermo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes please.

@silkeh silkeh merged commit ee743a3 into master Sep 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

solbuild delete-cache/dc -s/--size flag is under-documented
2 participants