Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add subgraph compatibility check #2234

Merged
merged 13 commits into from
May 21, 2024
Merged

add subgraph compatibility check #2234

merged 13 commits into from
May 21, 2024

Conversation

paulpdaniels
Copy link
Collaborator

@paulpdaniels paulpdaniels commented May 15, 2024 •
edited
Loading

Adding the subgraph compatibility check that should allow PRs to be check for breaking changes to federation.

Resolves #1730

@paulpdaniels paulpdaniels self-assigned this May 15, 2024
kyri-petrou
kyri-petrou reviewed May 15, 2024
View reviewed changes
apollo-compatibility/Dockerfile Outdated Show resolved Hide resolved
.github/workflows/compatibility.yaml Outdated Show resolved Hide resolved
@kyri-petrou
Copy link
Collaborator

@paulpdaniels disregard my review, only just realised the PR is still in draft 🤦

@paulpdaniels paulpdaniels reopened this May 15, 2024
@paulpdaniels paulpdaniels force-pushed the add-federation-compliance-check branch 2 times, most recently from d736cfa to 1345a3c Compare May 15, 2024 14:06
@ghostdogpr
Copy link
Owner

You can mention it resolves #1730

@paulpdaniels paulpdaniels force-pushed the add-federation-compliance-check branch from 39bcee6 to 358b0c5 Compare May 18, 2024 16:40
@paulpdaniels paulpdaniels marked this pull request as ready for review May 19, 2024 04:22
@paulpdaniels paulpdaniels force-pushed the add-federation-compliance-check branch from c1aeca6 to cc709ce Compare May 19, 2024 13:39
@paulpdaniels
Copy link
Collaborator Author

@ghostdogpr @kyri-petrou ready for re-review

kyri-petrou
kyri-petrou approved these changes May 20, 2024
View reviewed changes
build.sbt Show resolved Hide resolved
ghostdogpr
ghostdogpr reviewed May 21, 2024
View reviewed changes
Copy link
Owner

@ghostdogpr ghostdogpr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty cool! Not only can we use this for compatibility check, but it's also a good demo project for using Federation with Caliban. I think we should even add it to the docs 😄

build.sbt Show resolved Hide resolved
apollo-compatibility/README.md Outdated Show resolved Hide resolved
apollo-compatibility/src/main/scala/Main.scala Show resolved Hide resolved
@paulpdaniels paulpdaniels merged commit 378ef0d into ghostdogpr:series/2.x May 21, 2024
11 checks passed
@paulpdaniels paulpdaniels deleted the add-federation-compliance-check branch May 21, 2024 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ghostdogpr ghostdogpr ghostdogpr left review comments

@kyri-petrou kyri-petrou kyri-petrou approved these changes

Assignees

@paulpdaniels paulpdaniels

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Setup Apollo Federation spec compliance in CI
3 participants
@paulpdaniels @kyri-petrou @ghostdogpr