Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
ci-artifacts: do build with DEVELOPER=1
A recent MSYS2 update included an upgrade to GCC v14.1 which is a lot stricter than the previous version, leading to build errors when building Git under `DEVELOPER=1`. One symptom is: In file included from compat/regex/regex.c:72: compat/regex/regex_internal.c: In function 'create_ci_newstate': Error: compat/regex/regex_internal.c:1631:48: 'calloc' sizes specified with 'sizeof' in the earlier argument and not in the later argument [-Werror=calloc-transposed-args] 1631 | newstate = (re_dfastate_t *) calloc (sizeof (re_dfastate_t), 1); | ^~~~~~~~~~~~~ compat/regex/regex_internal.c:1631:48: note: earlier argument should specify number of elements, later size of each element This breaks all of Git's CI builds because the `setup-git-for-windows-sdk` GitHub Action looks for the latest successful `ci-artifacts` run (which did not build with `DEVELOPER=1`), uses the corresponding minimal SDK, and then builds with `DEVELOPER=1` and fails. Let's make `ci-artifacts` more stringent by building with `DEVELOPER=1` so that it does not succeed building Git when Git's own CI would fail at the same task with the same minimal SDK revision. Signed-off-by: Johannes Schindelin <[email protected]>
- Loading branch information