Do not redefine _FILE_STAT_LX_INFORMATION #5092
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csware
changed the title
csware
changed the title
dscho
requested changes
Aug 6, 2024
| @@ -54,6 +54,7 @@ int copy_wsl_mode_bits_from_disk(const wchar_t *wpath, ssize_t wpathlen, | |||
| return ret; | |||
| } | |||
|
|
|||
| #ifndef LX_FILE_METADATA_HAS_UID | |||
There was a problem hiding this comment.
Since this modifies a file that is not part of upstream Git yet, could you please mark this as a fixup! of 8342d6d instead of making it a stand-alone patch?
csware
force-pushed
the
fix-already-defined
branch
from
de2ebae to
6b262fb
Compare
dscho
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The struct definition as well as the other defines are already defined in Windows SDK >= 10.1.26100.1.