Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport linux32 CI fix from upstream Git #5145

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

dscho
Copy link
Member

@dscho dscho commented Sep 16, 2024

The linux32 jobs are seeing this error:

Error: This request has been automatically failed because it uses a
deprecated version of `actions/upload-artifact: v1`. Learn more:
https://github.blog/changelog/2024-02-13-deprecation-notice-v1-and-v2-of-the-artifact-actions/

To maintain CI builds that typically succeed, let's cherry-pick this into Git for Windows' main branch.

Linux32 jobs seem to be getting:

    Error: This request has been automatically failed because it uses a
    deprecated version of `actions/upload-artifact: v1`. Learn more:
    https://github.blog/changelog/2024-02-13-deprecation-notice-v1-and-v2-of-the-artifact-actions/

before doing anything useful.  For now, disable the step.

Ever since actions/upload-artifact@v1 got disabled, mentioning the
offending version of it seems to stop anything from happening.  At
least this should run the same build and test.

See

    https://github.com/git/git/actions/runs/10780030750/job/29894867249

for example.

Cherry-picked-from: 90f2c72 (ci: remove 'Upload failed tests' directories' step from linux32 jobs, 2024-09-09)
Signed-off-by: Junio C Hamano <[email protected]>
Signed-off-by: Johannes Schindelin <[email protected]>
@dscho dscho added this to the v2.46.1 milestone Sep 16, 2024
@dscho dscho self-assigned this Sep 16, 2024
@dscho
Copy link
Member Author

dscho commented Sep 16, 2024

I would have expected that patch to show up in v2.46.1, but it did not.

@dscho dscho merged commit 78d0106 into git-for-windows:main Sep 16, 2024
44 checks passed
@dscho dscho deleted the backport-linux32-workaround branch September 16, 2024 10:27
git-for-windows-ci pushed a commit that referenced this pull request Sep 16, 2024
The `linux32` jobs are seeing this error:

    Error: This request has been automatically failed because it uses a
    deprecated version of `actions/upload-artifact: v1`. Learn more:

https://github.blog/changelog/2024-02-13-deprecation-notice-v1-and-v2-of-the-artifact-actions/

To maintain CI builds that typically succeed, let's cherry-pick this
into Git for Windows' `main` branch.
dscho added a commit that referenced this pull request Sep 16, 2024
The `linux32` jobs are seeing this error:

    Error: This request has been automatically failed because it uses a
    deprecated version of `actions/upload-artifact: v1`. Learn more:

https://github.blog/changelog/2024-02-13-deprecation-notice-v1-and-v2-of-the-artifact-actions/

To maintain CI builds that typically succeed, let's cherry-pick this
into Git for Windows' `main` branch.
git-for-windows-ci pushed a commit that referenced this pull request Sep 16, 2024
The `linux32` jobs are seeing this error:

    Error: This request has been automatically failed because it uses a
    deprecated version of `actions/upload-artifact: v1`. Learn more:

https://github.blog/changelog/2024-02-13-deprecation-notice-v1-and-v2-of-the-artifact-actions/

To maintain CI builds that typically succeed, let's cherry-pick this
into Git for Windows' `main` branch.
dscho added a commit to dscho/git that referenced this pull request Sep 18, 2024
The `linux32` jobs are seeing this error:

    Error: This request has been automatically failed because it uses a
    deprecated version of `actions/upload-artifact: v1`. Learn more:

https://github.blog/changelog/2024-02-13-deprecation-notice-v1-and-v2-of-the-artifact-actions/

To maintain CI builds that typically succeed, let's cherry-pick this
into Git for Windows' `main` branch.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants