Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to go 1.20 #114

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Move to go 1.20 #114

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
FROM golang:1.14.7
MAINTAINER GitHub, Inc.
FROM golang:1.20
LABEL org.opencontainers.image.authors=" GitHub, Inc."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it's accurate to say that GitHub is the author here, since this is an open source project and anyone can contribute, and you're contributing here. It's accurate that GitHub is the maintainer, so let's either back this change out or just remove the maintainer altogether.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MAINTAINER is deprecated, with *.authors being the suggested replacement.

I get your point, though! Let me see if i can find a more suitable standard label.

If not, either removal or reverting is fine with me. Between the two, do you have a preference?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, my thinking is to replace the text of *.authors with the first line of the LICENSE file, and supply the *.url, *.documentation, and *.source URLs, I guess pointing to the Dockerfile, README.md, and repo, respectively.

I'll see about making it a concrete change later (incorporating any feedback you may have by then).

Reference:
https://github.com/opencontainers/image-spec/blob/main/annotations.md

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(First line of the LICENSE file, to save you the trouble):

Copyright (c) GitHub, Inc. and LFS Test Server contributors

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd just remove the entry altogether in that case. I don't think it provides a lot of value in general.


WORKDIR /go/src/github.com/git-lfs/lfs-test-server

Expand Down
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,4 +6,4 @@ require (
github.com/gorilla/mux v0.0.0-20140926153814-e444e69cbd2e
)

go 1.16
go 1.20