Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add proof of concept drag & drop e2e test #5745

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Add proof of concept drag & drop e2e test #5745

wants to merge 3 commits into from

Conversation

mtsgrd
Copy link
Contributor

@mtsgrd mtsgrd commented Dec 5, 2024 •
edited
Loading

This is part 2 of 2 in a stack made with GitButler:

@mtsgrd mtsgrd mentioned this pull request Dec 5, 2024
Merged
@vercel Vercel
Copy link

vercel bot commented Dec 5, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
gitbutler-components ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 5, 2024 0:36am
gitbutler-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 5, 2024 0:36am

mtsgrd
mtsgrd commented Dec 5, 2024
View reviewed changes
apps/desktop/e2e/tests/drag-file.spec.ts Outdated
await dropTarget.waitForDisplayed();

// The actual drop target can be different from the element with the `dropZone` directive..
await driver.executeScript(dragAndDrop, [fileSelector, dropSelector + ' .dropzone-target']);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ndom91 this used to work - likely the difference is on our side somewhere. No rush at all, but if you could at any point help me debug this? 🙏

From last time, I remember that the change in dropzone.ts was important. The current problem might be similar or related.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, I resolved it in the last force push.

@mtsgrd mtsgrd changed the base branch from Add-Dockerfile-for-e2e-tests-on-mac to master December 7, 2024 20:44
@ndom91
Copy link
Contributor

ndom91 commented Dec 9, 2024 •
edited
Loading

Sorry for the huge screenshot. Wanted to get both the test client and the terminal in my VM in though haha.

image

Looks like it's getting stuck at finishing adding the project, i.e. the "Let's go" btn and then doesn't continue on to the board. At which point it eventually fails retrying looking for the "Workspace" button.

EDIT: That was for the first test. For the second it looks like it's just failing finding that initial data-testid=file-hello selector. Let me do some more debugging 🤔

@ndom91
Copy link
Contributor

ndom91 commented Dec 9, 2024

A little more debugging and ensuring the gitbutler-git and gitbutler-cli were both compiled and the first add-project test passed.

Your new one, drag-file, hwoever, I couldn't get to pass yet. It always got stuck on either the "accept analytics" page or after that at the "add project" page. It seems like the project added in the previous test wasn't available here although the test seems to be written from the perspective of already having a project added and available 🤔

Happy to debug together some more tomorrow 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
@gitbutler/desktop @gitbutler/ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mtsgrd @ndom91