-
Notifications
You must be signed in to change notification settings - Fork 552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: compress signed msi for download by tauri updater #5820
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
f9cc656
to
740d397
Compare
740d397
to
9f8b9be
Compare
9f8b9be
to
50bf801
Compare
@schacon unfortunately wasn't able to finish this before holidays. Running this in GHA produced all sorts of dumb issues like not finding So definitely needs some more debugging, but anyway here's the |
50bf801
to
c1b67e5
Compare
.github/workflows/publish.yaml
Outdated
id: set-path | ||
run: | | ||
VALUE=$(find release -name "*.msi" -type f -printf '%P\n') | ||
echo "::set-output name=msi_file::$VALUE" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this syntax still supported? I thought it was:
- name: Set output
run: echo "{name}={value}" >> $GITHUB_OUTPUT
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Old school.
Technically they are still supported, but yes, I will change them to the new format.
5110d1e
to
8a1a670
Compare
8a1a670
to
8f4786c
Compare
8f4786c
to
6c3f07f
Compare
0bd4ca8
to
f327cd9
Compare
f327cd9
to
7192885
Compare
7192885
to
0bb81d0
Compare
0bb81d0
to
d8fe0aa
Compare
d8fe0aa
to
3a69fab
Compare
3a69fab
to
351f0bf
Compare
351f0bf
to
a043110
Compare
a043110
to
d84b2d2
Compare
☕️ Reasoning
*.msi.zip
in the S3 bucket dir for download by the Tauri updater.🧢 Changes