Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: compress signed msi for download by tauri updater #5820

Merged
merged 3 commits into from
Dec 17, 2024

Conversation

ndom91
Copy link
Contributor

@ndom91 ndom91 commented Dec 12, 2024

☕️ Reasoning

  • Compress the MSI after signing and replace the unsigned *.msi.zip in the S3 bucket dir for download by the Tauri updater.

🧢 Changes

Copy link

vercel bot commented Dec 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
gitbutler-components ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 17, 2024 10:00am
gitbutler-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 17, 2024 10:00am

@ndom91
Copy link
Contributor Author

ndom91 commented Dec 12, 2024

@schacon unfortunately wasn't able to finish this before holidays. Running this in GHA produced all sorts of dumb issues like not finding zip, then not allowing sudo apt install zip, then not finding sudo, then running apt install zip couldn't resolve packages.ubuntu.org, etc etc 😂

So definitely needs some more debugging, but anyway here's the minisign-cli GHA you mentioned: https://github.com/marketplace/actions/minisign-cli. Feel free to add it here

id: set-path
run: |
VALUE=$(find release -name "*.msi" -type f -printf '%P\n')
echo "::set-output name=msi_file::$VALUE"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this syntax still supported? I thought it was:

- name: Set output
  run: echo "{name}={value}" >> $GITHUB_OUTPUT

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Old school.

Technically they are still supported, but yes, I will change them to the new format.

@schacon schacon force-pushed the fix-compress-signed-msi branch from 0bd4ca8 to f327cd9 Compare December 16, 2024 16:26
@schacon schacon force-pushed the fix-compress-signed-msi branch from f327cd9 to 7192885 Compare December 16, 2024 18:09
@schacon schacon force-pushed the fix-compress-signed-msi branch from 7192885 to 0bb81d0 Compare December 16, 2024 18:12
@schacon schacon force-pushed the fix-compress-signed-msi branch from 0bb81d0 to d8fe0aa Compare December 16, 2024 20:01
@schacon schacon force-pushed the fix-compress-signed-msi branch from d8fe0aa to 3a69fab Compare December 17, 2024 07:05
@schacon schacon force-pushed the fix-compress-signed-msi branch from 3a69fab to 351f0bf Compare December 17, 2024 08:17
@schacon schacon force-pushed the fix-compress-signed-msi branch from 351f0bf to a043110 Compare December 17, 2024 08:56
@schacon schacon force-pushed the fix-compress-signed-msi branch from a043110 to d84b2d2 Compare December 17, 2024 09:59
@schacon schacon merged commit 178ec76 into master Dec 17, 2024
21 checks passed
@schacon schacon deleted the fix-compress-signed-msi branch December 17, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants