Create re-usable file service for reading git blobs #5884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- decouples reading from workspace from reading from commit
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@Caleb-T-Owens could this be helpful in resolving #5826? It would currently return the full file ofc. |
mtsgrd
force-pushed
the
create-file-service
branch
from
9e9f2d7 to
abf395a
Compare
Yes, it could be used in the cases where the two sides have both modified the same file. It would need a bit more consideration as to how we display files that have been modified & deleted though. |
mtsgrd
force-pushed
the
create-file-service
branch
from
abf395a to
a792b6e
Compare
mtsgrd
force-pushed
the
create-file-service
branch
from
a792b6e to
acc4c53
Compare
mtsgrd
force-pushed
the
create-file-service
branch
from
acc4c53 to
b582d79
Compare
Caleb-T-Owens
approved these changes
Jan 3, 2025
estib-vega
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FileDiffcomponent from reading file for every diff