Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Free Art License 1.3 #677
base: gh-pages
Are you sure you want to change the base?
Add Free Art License 1.3 #677
Changes from 2 commits
1dc9cf9
8ea0766
921be65
1a15f76
06e5c6a
2c79570
ed3a107
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I imagine the license text must be copied from https://github.com/spdx/license-list-data/blob/7364995d38090ad40b8aa54d99b322ac8730d2e1/text/LAL-1.3.txt ... that's definitely the right place to start, but it looks like it has some quirks (ie bugs in the SPDX XML markup and/or XML-to-text rendering); this line stands out, as do the doublespaced list items.
Do you know of a plain text version (French) that has been published by artlibre.org and/or is in wide use to compare against? I guess the examples requested above will be good indicators.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The strange spacing is in the original text, which is http://artlibre.org/
It's remains at https://spdx.org/licenses/LAL-1.3.html and in their repositories
There is also https://fr.wikipedia.org/wiki/Wikip%C3%A9dia:Licence_Art_Libre
Wikipedia says that ": ; ? and ! are always preceded by a thin unbreakable space". I'm assuming full width spaces were used, and it's breaking that line. Elsewhere it mentions nonbreaking spaces for before and after those characters: https://en.wikipedia.org/wiki/French_orthography#Punctuation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I saw that the spacing around punctuation is in the original. I meant the spacing between lines, and in the one line I'm highlighting here, oddly aggressive line wrapping just before punctuation. In any case, let's see what the full French text examples you find look like, and we'll see if any issues or PRs should be filed with SPDX about their text rendered version (which I very much want to be aligned with).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the punctuation spacing, I think either U+00A0 or U+202F might look better. Apparently the thin non-breaking space only goes before the punctuation.
For the bigger problem of spacing between lines, it definitely seems like LAL-1.3.xml got thrown off somewhere, it looks like starting at line 47. There is also an (I think) unnecessary/redundant
<p>
element at line 122 and a missing<br>
element at 165. For these reasons I went ahead and made a version, working from GPL-3.0.xml as a pattern. It's at spdx/license-list-XML#915