Convert model from QL to MaD

github · Dec 13, 2024 · 88256e2 · 88256e2
1 parent f844105
commit 88256e2
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 6 deletions.
diff --git a/go/ql/lib/ext/os.model.yml b/go/ql/lib/ext/os.model.yml
@@ -46,6 +46,7 @@ extensions:
       pack: codeql/go-all
       extensible: sourceModel
     data:
+      - ["os", "", False, "Args", "", "", "", "commandargs", "manual"]
       - ["os", "", False, "Environ", "", "", "ReturnValue", "environment", "manual"] # TODO: when sources can have access paths, use .ArrayElement
       - ["os", "", False, "ExpandEnv", "", "", "ReturnValue", "environment", "manual"]
       - ["os", "", False, "Getenv", "", "", "ReturnValue", "environment", "manual"]

diff --git a/go/ql/lib/semmle/go/frameworks/stdlib/Os.qll b/go/ql/lib/semmle/go/frameworks/stdlib/Os.qll
@@ -43,10 +43,4 @@ module Os {
       input = inp and output = outp
     }
   }
-
-  private class ArgsSource extends SourceNode {
-    ArgsSource() { exists(Variable v | v.hasQualifiedName("os", "Args") | this = v.getARead()) }
-
-    override string getThreatModel() { result = "commandargs" }
-  }
 }