Merge pull request #16230 from MathiasVP/fix-join-in-global-use-befor…

…e-init C++: Use interpolation to avoid a bad join order
github · Apr 16, 2024 · 8f82db0 · 8f82db0
2 parents 4cb0695 + c3cf425
commit 8f82db0
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/cpp/ql/src/Critical/GlobalUseBeforeInit.ql b/cpp/ql/src/Critical/GlobalUseBeforeInit.ql
@@ -110,6 +110,5 @@ from GlobalVariable v, Function f
 where
   uninitialisedBefore(v, f) and
   useFunc(v, f)
-select f,
-  "The variable '" + v.getName() + "'" +
-    " is used in this function but may not be initialized when it is called."
+select f, "The variable $@ is used in this function but may not be initialized when it is called.",
+  v, v.getName()
diff --git a/cpp/ql/test/query-tests/Critical/GlobalUseBeforeInit/GlobalUseBeforeInit.expected b/cpp/ql/test/query-tests/Critical/GlobalUseBeforeInit/GlobalUseBeforeInit.expected
@@ -1 +1 @@
-| test.cpp:27:5:27:6 | f1 | The variable 'b' is used in this function but may not be initialized when it is called. |
+| test.cpp:27:5:27:6 | f1 | The variable $@ is used in this function but may not be initialized when it is called. | test.cpp:14:5:14:5 | b | b |
Original file line number	Diff line number	Diff line change
		@@ -1 +1 @@
		\| test.cpp:27:5:27:6 \| f1 \| The variable 'b' is used in this function but may not be initialized when it is called. \|
		\| test.cpp:27:5:27:6 \| f1 \| The variable $@ is used in this function but may not be initialized when it is called. \| test.cpp:14:5:14:5 \| b \| b \|