Improve log messages

github · Apr 17, 2024 · bef556e · bef556e
1 parent 5a5fc79
commit bef556e
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 7 deletions.
diff --git a/csharp/extractor/Semmle.Extraction.CSharp.DependencyFetching/Sdk.cs b/csharp/extractor/Semmle.Extraction.CSharp.DependencyFetching/Sdk.cs
@@ -63,10 +63,10 @@ private static HashSet<DotNetVersion> ParseSdks(IList<string> listed)
             }
 
             var path = Path.Combine(sdk.FullPath, "Roslyn", "bincore", "csc.dll");
-            logger.LogInfo($"Source generator CSC: '{path}'");
+            logger.LogDebug($"Source generator CSC: '{path}'");
             if (!File.Exists(path))
             {
-                logger.LogInfo($"csc.dll not found at '{path}'.");
+                logger.LogWarning($"csc.dll not found at '{path}'.");
                 return null;
             }
 

diff --git a/...Semmle.Extraction.CSharp.DependencyFetching/SourceGenerators/DotnetSourceGeneratorBase.cs b/...Semmle.Extraction.CSharp.DependencyFetching/SourceGenerators/DotnetSourceGeneratorBase.cs
@@ -34,19 +34,17 @@ protected override IEnumerable<string> Run()
             var additionalFiles = AdditionalFiles;
             if (additionalFiles.Count == 0)
             {
-                logger.LogDebug($"No {FileType} files found.");
+                logger.LogDebug($"No {FileType} files found. Skipping source generation.");
                 return [];
             }
 
-            logger.LogInfo($"Found {additionalFiles.Count} {FileType} files.");
-
             if (!fileContent.IsAspNetCoreDetected)
             {
                 logger.LogInfo($"Generating source files from {FileType} files is only supported for new (SDK-style) project files");
                 return [];
             }
 
-            logger.LogInfo($"Generating source files from {FileType} files...");
+            logger.LogInfo($"Generating source files from {additionalFiles.Count} {FileType} files...");
 
             try
             {

diff --git a/...ncyFetching/SourceGenerators/DotnetSourceGeneratorWrapper/DotnetSourceGeneratorWrapper.cs b/...ncyFetching/SourceGenerators/DotnetSourceGeneratorWrapper/DotnetSourceGeneratorWrapper.cs
@@ -45,7 +45,7 @@ public IEnumerable<string> RunSourceGenerator(IEnumerable<string> additionalFile
 
             try
             {
-                logger.LogInfo("Produce analyzer config content.");
+                logger.LogInfo("Producing analyzer config content.");
                 GenerateAnalyzerConfig(additionalFiles, analyzerConfig);
 
                 logger.LogDebug($"Analyzer config content: {File.ReadAllText(analyzerConfig)}");