Skip to content

Commit

Permalink
Address review comments - Fix docs typo and add a reference
Browse files Browse the repository at this point in the history
  • Loading branch information
joefarebrother committed Mar 25, 2024
1 parent 592acb9 commit fb19288
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions ruby/ql/src/queries/security/cwe-915/MassAssignment.qhelp
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<overview>
<p>
Operations that allow for mass assignment (setting multiple attributes of an object using a hash), such as <code>ActiveRecord::Base.new</code>, should take care not to
allow arbitrary parameters to be set by the user. Otherwise, unintended attributes may be set, such as an <code>isAdmin</code> feild for a <code>User</code> object.
allow arbitrary parameters to be set by the user. Otherwise, unintended attributes may be set, such as an <code>is_admin</code> field for a <code>User</code> object.
</p>
</overview>
<recommendation>
Expand All @@ -29,6 +29,6 @@
</example>

<references>

<li>Rails guides: <a href="https://guides.rubyonrails.org/action_controller_overview.html#strong-parameters">Strong Parameters</a>.</li>
</references>
</qhelp>

0 comments on commit fb19288

Please sign in to comment.