Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

All: delete outdated deprecations #15393

Merged
merged 4 commits into from
Jan 23, 2024
Merged

All: delete outdated deprecations #15393

merged 4 commits into from
Jan 23, 2024

Conversation

erik-krogh
Copy link
Contributor

@erik-krogh erik-krogh commented Jan 22, 2024 •
edited
Loading

Similar to last time: #14403

@erik-krogh erik-krogh added the WIP This is a work-in-progress, do not merge yet! label Jan 22, 2024
@erik-krogh erik-krogh changed the title delete outdated deprecations All: delete outdated deprecations Jan 22, 2024
@erik-krogh erik-krogh marked this pull request as ready for review January 22, 2024 18:34
@erik-krogh erik-krogh requested review from a team as code owners January 22, 2024 18:34
michaelnebel
michaelnebel approved these changes Jan 23, 2024
View reviewed changes
Copy link
Contributor

@michaelnebel michaelnebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C#: LGTM!

jketema
jketema approved these changes Jan 23, 2024
View reviewed changes
Copy link
Contributor

@jketema jketema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C++ 👍

atorralba
atorralba approved these changes Jan 23, 2024
View reviewed changes
Copy link
Contributor

@atorralba atorralba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Java 👍

smowton
smowton approved these changes Jan 23, 2024
View reviewed changes
Copy link
Contributor

@smowton smowton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go 👍

tausbn
tausbn approved these changes Jan 23, 2024
View reviewed changes
Copy link
Contributor

@tausbn tausbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

@erik-krogh erik-krogh merged commit f1d6f56 into github:main Jan 23, 2024
51 checks passed
@Marcono1234 Marcono1234 mentioned this pull request Feb 8, 2024
Merged
@erik-krogh erik-krogh mentioned this pull request Apr 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jketema jketema jketema approved these changes

@atorralba atorralba atorralba approved these changes

@aibaars aibaars aibaars approved these changes

@michaelnebel michaelnebel michaelnebel approved these changes

@hvitved hvitved hvitved approved these changes

@tausbn tausbn tausbn approved these changes

@smowton smowton smowton approved these changes

Assignees
No one assigned
Labels
C# C++ documentation Go Java JS Python QL-for-QL Ruby WIP This is a work-in-progress, do not merge yet!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@erik-krogh @smowton @tausbn @hvitved @michaelnebel @aibaars @atorralba @jketema