C#: Fix issue with suppress nullable warning directly on a method call. #16186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelnebel
force-pushed
the
csharp/suppressnullablefix
branch
from
34781d5 to
f208a13
Compare
michaelnebel
force-pushed
the
csharp/suppressnullablefix
branch
from
5ea9fe4 to
183cc66
Compare
michaelnebel
force-pushed
the
csharp/suppressnullablefix
branch
from
183cc66 to
cbb5d43
Compare
|
I think that DCA looks good, but it is hard to judge from all the noise (1) Performance is acceptable (2) The alert diff only shows diffs on non-security related queries and when spot checking the results, it appears that they are not related to the change in this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out that the extractor is somewhat broken for suppress nullable warning expressions like
System.Console.ReadLine()!.The extraction worked correctly when the suppressing nullable warnings on identifiers, but not directly on the result of calls.
Even though
!is referred to as an operator, it has no semantical meaning during program execution (this is only an instruction to the compiler) and is just a piece of syntax without any associated method symbol.Comment to the code change: Note that
PostfixUnaryis only used for++,--and!.