Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C#: Logging #16200

Merged
merged 5 commits into from
Apr 16, 2024
Merged

C#: Logging #16200

merged 5 commits into from
Apr 16, 2024

Conversation

michaelnebel
Copy link
Contributor

Replaced some LogInfo with LogDebug (some of the more chatty LogInfo).

@tamasvajk : Should we consider to use LogDebug when executing commands (most of the onOut callbacks - prints as Info)?

@github-actions github-actions bot added the C# label Apr 12, 2024
@tamasvajk
Copy link
Contributor

@tamasvajk : Should we consider to use LogDebug when executing commands (most of the onOut callbacks - prints as Info)?

Yes, I think we should change those as well. (Maybe I wouldn't do it for dotnet --info.) Additionally, I'd also make the ... (processing started) messages debug ones too.

@michaelnebel michaelnebel force-pushed the csharp/dependencylogging branch from 03e00a2 to 8915241 Compare April 15, 2024 11:01
github-advanced-security[bot]
github-advanced-security bot found potential problems Apr 15, 2024
View reviewed changes
csharp/extractor/Semmle.Extraction.Tests/DotNet.cs
{
lastArgs = args;
output = this.output;
return Success;
}

public bool RunCommand(string args, string? workingDirectory, out IList<string> output)
public bool RunCommand(string args, string? workingDirectory, out IList<string> output, bool silent)

Check notice

Code scanning / CodeQL

Local scope variable shadows member Note test

Local scope variable 'output' shadows
DotNetCliInvokerStub.output
Loading
.
@michaelnebel michaelnebel added the no-change-note-required This PR does not need a change note label Apr 15, 2024
@michaelnebel michaelnebel marked this pull request as ready for review April 15, 2024 12:03
@michaelnebel michaelnebel requested a review from a team as a code owner April 15, 2024 12:03
@michaelnebel michaelnebel merged commit 3105697 into github:main Apr 16, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tamasvajk tamasvajk tamasvajk approved these changes

Assignees
No one assigned
Labels
C# no-change-note-required This PR does not need a change note
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michaelnebel @tamasvajk