Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade rules_pkg to 0.10.1. #16229

Merged
merged 1 commit into from
Apr 16, 2024
Merged

Upgrade rules_pkg to 0.10.1. #16229

merged 1 commit into from
Apr 16, 2024

Conversation

criemen
Copy link
Collaborator

@criemen criemen commented Apr 16, 2024

No description provided.

@criemen criemen added the depends on internal PR This PR should only be merged in sync with an internal Semmle PR label Apr 16, 2024
@criemen criemen marked this pull request as ready for review April 16, 2024 14:43
@criemen criemen requested review from a team as code owners April 16, 2024 14:43
tausbn
tausbn approved these changes Apr 16, 2024
View reviewed changes
Copy link
Contributor

@tausbn tausbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Python 👍
(And the rest as well, as far as I can tell.)

@criemen criemen merged commit 4cb0695 into main Apr 16, 2024
32 of 49 checks passed
@criemen criemen deleted the criemen/rules-pkg branch April 16, 2024 16:03
michaelnebel
michaelnebel reviewed Apr 17, 2024
View reviewed changes
Copy link
Contributor

@michaelnebel michaelnebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C# LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelnebel michaelnebel michaelnebel left review comments

@oscarsj oscarsj oscarsj approved these changes

@tausbn tausbn tausbn approved these changes

@mbg mbg mbg approved these changes

Assignees
No one assigned
Labels
C# C++ depends on internal PR This PR should only be merged in sync with an internal Semmle PR Java JS Python Ruby Swift
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@criemen @mbg @tausbn @oscarsj @michaelnebel