C++: Fix toString on non-ExprNodes
#16242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MathiasVP
force-pushed
the
fix-tostring-on-nodes
branch
from
c03e4eb to
ba91973
Compare
MathiasVP
force-pushed
the
fix-tostring-on-nodes
branch
from
ba91973 to
58832a5
Compare
MathiasVP
added
the
depends on internal PR
jketema
approved these changes
Apr 18, 2024
|
Hm, yes I think so. I thought I had started one, but it looks like I didn't. I'll do that right away! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
toStringon dataflow nodes that are notExprNodes hasn't gotten as much attention as the ones that areExprNodes (i.e., the ones you can obtain by doingNode.asExpr()orNode.asIndirectExpr()). When we started showing some of these in path explanations in #16203 @jketema noticed that thetoStringwas giving back implicitly and explicitly converted expressions.This PR changes this by making sure that the
toStringon these nodes always use the unconverted expression when possible, and otherwise it falls back to the old behavior.Note that this behavior changes only the
toStringand not which expressions are obtainable usingNode.asExpr(). So it should be a very uncontroversial change that simply improves the presentation in path explanations.