C#: Do not call CSharpCompilation.Clone
#16249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hvitved
changed the title
CSharpCompilation.CloneCSharpCompilation.Clone
michaelnebel
approved these changes
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Despite what the original comment said, calling
CSharpCompilation.Cloneactually makes the extractor consume more memory instead of less memory, at least when running in buildless mode, where all.csfiles are included in one single compilation.Running buildless extraction on
dotnet/roslynlocally with/usr/bin/time -lreported amaximum resident set sizeof51,035,299,840before this PR and15,477,882,880after.DCA confirms that this is an improvement, as the database build time for
mono/monoandOrchardCMS/OrchardCoredecrease by 70% in buildless mode.