C#: Improve log messages #16321
Merged
C#: Improve log messages #16321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelnebel
previously approved these changes
Apr 25, 2024
| @@ -91,9 +91,9 @@ public bool AddPackage(string folder, string package) | |||
| return dotnetCliInvoker.RunCommand(args); | |||
| } | |||
|
|
|||
| public IList<string> GetListedRuntimes() => GetResultList("--list-runtimes", null, false); | |||
| public IList<string> GetListedRuntimes() => GetResultList("--list-runtimes", null, true); | |||
There was a problem hiding this comment.
nit: No need to supplu null and true as these are the defaults.
|
|
||
| public IList<string> GetListedSdks() => GetResultList("--list-sdks", null, false); | ||
| public IList<string> GetListedSdks() => GetResultList("--list-sdks", null, true); |
| } | ||
|
|
||
| public void MissingSummary(int missingTypes, int missingNamespaces) | ||
| { | ||
| logger.Log(Severity.Info, "Failed to resolve {0} types in {1} namespaces", missingTypes, missingNamespaces); | ||
| if (missingTypes > 0 || missingNamespaces > 0) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.