Rust: introduce Unextracted and Missing "marker" classes
#17479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that this will probably interact with #17465 (i.e. whichever is merged first, the other may need to be updated). |
Actually, I'm not entirely sure these PRs will really interact: I think #17465 can keep on referencing the specific subclasses ( |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -43,6 +43,7 @@ | |||
| import codeql.rust.elements.MatchArm | |||
| import codeql.rust.elements.MatchExpr | |||
| import codeql.rust.elements.MethodCallExpr | |||
| import codeql.rust.elements.Missing | |||
Check warning
Code scanning / CodeQL
Redundant import Warning
| @@ -70,6 +71,7 @@ | |||
| import codeql.rust.elements.TupleStructPat | |||
| import codeql.rust.elements.TypeRef | |||
| import codeql.rust.elements.UnderscoreExpr | |||
| import codeql.rust.elements.Unextracted | |||
Check warning
Code scanning / CodeQL
Redundant import Warning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces
Missingas a superclass ofMissingExprandMissingPat, andUnextractedas a superclass of bothMissingandUnimplemented. This should allow us to run more precise metrics about what we consider as properly extracted, by excludingUnextracted.