Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rust: rename TypeRef and *Type to *TypeRepr, ty to type_repr, and expand some abbreviations in generated docs #18174

Merged
merged 12 commits into from
Dec 4, 2024
Merged

Rust: rename TypeRef and *Type to *TypeRepr, ty to type_repr, and expand some abbreviations in generated docs #18174

Show file tree
Hide file tree
Changes from 11 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
5d3c9d0
Rust: expand `Pat` in documentation
Dec 2, 2024
99bd75c
Rust: expand `Ty` in documentation
Dec 2, 2024
e7ffddd
Rust: rename all `*Type` to `*TypeRef`
Dec 2, 2024
2a7ce9a
Rust: accept all test changes
Dec 2, 2024
43eba85
Merge branch 'main' into redsun82/rust-tweaks
Dec 2, 2024
0a93a31
Rust: accept all test changes after merge
Dec 2, 2024
e89cf30
Rust: rename `TypeRef` -> `TypeRepr`
Dec 2, 2024
b99e234
Merge branch 'main' into redsun82/rust-tweaks
Dec 3, 2024
8287cdd
Rust: accept test changes
Dec 3, 2024
db18d10
Rust: rename `getTy` -> `getTypeRepr`
Dec 3, 2024
952f41e
Rust: fix broken test
Dec 3, 2024
5350300
Merge branch 'main' into redsun82/rust-tweaks
Dec 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
1 change: 1 addition & 0 deletions misc/codegen/generators/qlgen.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,7 @@ class NoClasses(Error):
"int": "integer",
"var": "variable",
"ref": "reference",
"pat": "pattern",
}

abbreviations.update({f"{k}s": f"{v}s" for k, v in abbreviations.items()})
Expand Down
19 changes: 10 additions & 9 deletions rust/ast-generator/src/main.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,15 +15,14 @@ fn project_root() -> PathBuf {
}

fn class_name(type_name: &str) -> String {
let name = match type_name {
"BinExpr" => "BinaryExpr",
"ElseBranch" => "Expr",
"Fn" => "Function",
"Literal" => "LiteralExpr",
"Type" => "TypeRef",
_ => type_name,
};
name.to_owned()
match type_name {
"BinExpr" => "BinaryExpr".to_owned(),
"ElseBranch" => "Expr".to_owned(),
"Fn" => "Function".to_owned(),
"Literal" => "LiteralExpr".to_owned(),
_ if type_name.ends_with("Type") => format!("{}Repr", type_name),
_ => type_name.to_owned(),
}
}

fn property_name(type_name: &str, field_name: &str) -> String {
Expand All @@ -34,6 +33,8 @@ fn property_name(type_name: &str, field_name: &str) -> String {
("Path", "segment") => "part",
(_, "then_branch") => "then",
(_, "else_branch") => "else_",
("ArrayType", "ty") => "element_type_repr",
(_, "ty") => "type_repr",
_ => field_name,
};
name.to_owned()
Expand Down
2 changes: 1 addition & 1 deletion rust/extractor/src/generated/.generated.list
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading