Rust: Add data flow tests for operator overloading #18312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
paldepind
requested changes
Dec 18, 2024
paldepind
requested changes
Dec 18, 2024
paldepind
requested changes
Dec 18, 2024
Comment on lines
103
to
104
| fn add(self, other: MyInt) -> MyInt { | ||
| // Ignore `other` to get value flow for `self.value` |
There was a problem hiding this comment.
Sorry for coming up with one more nitpick comment 🙈
Suggested change
| fn add(self, other: MyInt) -> MyInt { | |
| // Ignore `other` to get value flow for `self.value` | |
| fn add(self, _other: MyInt) -> MyInt { | |
| // Ignore `_other` to get value flow for `self.value` |
hvitved
force-pushed
the
rust/operator-overloading-test
branch
from
843e0a2 to
2f9f574
Compare
Co-authored-by: Simon Friis Vindum <[email protected]>
hvitved
force-pushed
the
rust/operator-overloading-test
branch
from
2f9f574 to
3a63dbc
Compare
paldepind
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a few data flow tests that illustrate the current shortcomings of flow through operator calls.