Rust: Value flow and taint flow through formatting strings #18394
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds:
format_args!
to theformat_args!
expression itself.format!
.The original goal was to get taint through the
format!
macro. But since its definition uses alet
statement, the issue in #18330 prevents that from working. But once that is fixed, the changes here should give flow throughfomat!
.MacroCall
s are now included in the CFG in post-order. Previously they where skipped over and not included in the CFG, but this caused thegetMacroCall
predicate onMacroExprCfgNode
to never have any results. Including them in the CFG fixes that, and I don't think there's any reason to exclude them.