-
Notifications
You must be signed in to change notification settings - Fork 60.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add note about restarting the runner service after changing the .env … #35356
base: main
Are you sure you want to change the base?
Conversation
Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines. |
Automatically generated comment ℹ️This comment is automatically generated and will be overwritten every time changes are committed to this branch. The table contains an overview of files in the Content directory changesYou may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.
fpt: Free, Pro, Team |
@christianspecht Thanks so much for opening a PR! I'll get this triaged for review ✨ |
Thanks for opening a pull request! We've triaged this issue for technical review by a subject matter expert 👀 |
This comment was marked as spam.
This comment was marked as spam.
@christianspecht Thank you so much for your patience while our SME team reviewed! 💛 They thanked you for the PR, and offered the following guidance -
Please let us know if you'd be willing to update your PR to match this guidance - thank you ✨ |
This comment was marked as spam.
This comment was marked as spam.
Yes, will do. Give me a few days. |
This PR has been automatically closed because there has been no response to to our request for more information from the original author. Please reach out if you have the information we requested, or open a new issue to describing your changes. Then we can begin the review process. |
@nguyenalex836: I made the changes requested by the SME team, but a few hours too late as my PR has been auto-closed in the meantime I pushed a new commit to my fork, but it's not visible here, probably because the PR is closed. Here's a diff how my change looks now. Thanks! |
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
@christianspecht Apologies on behalf of our bot! Thank you for making those updates ✨ Your changes look perfect! We are currently in a repo freeze, but we'll get this merged as soon as the freeze ends on Jan 6th 💛 |
…file
Why:
Because I spent about half an hour scratching my head why my script defined in the
.env
file was not executed, until I had the idea to restart the runner service.I assumed that the runner read the file before each job run, IMO it's not obvious that it only happens after restarting.
IMO it's not obvious that the runner only reads the file after restarting, I assumed that it happens before each job run.
Closes:
What's being changed (if available, include any code snippets, screenshots, or gifs):
Check off the following:
I have reviewed my changes in staging, available via the View deployment link in this PR's timeline (this link will be available after opening the PR).
data
directory.For content changes, I have completed the self-review checklist.