Implement symmetric text padding from edges #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkhuzaima
requested review from
chrisreddington and
leereilly
as code owners
There was a problem hiding this comment.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
mkhuzaima
commented
Dec 14, 2024
| } | ||
|
|
||
| yearConfig := textRenderConfig{ | ||
| renderConfig: renderConfig{ | ||
| startX: innerWidth * yearPosition, | ||
| startX: innerWidth*(1-textPadding) - 75, |
There was a problem hiding this comment.
By chosing 75, It exaclty aligns with right side of the cuboid.
The number was chosen by hit-and-trial method.
mkhuzaima
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Username and year are now have same padding from the edges. Padding is kept 10% for now, and, is customizable.
I have used alignment alongwith DrawStringWrapped method, to align username and year on the left and right side of
gg.Contextrespectively.Fixes #12.