fix: Move 'noTitle' conditional.

Calculate the new title, just don’t update the attribute. This change means the 'relative-time-updated' event will fire even if 'noTitle' is set.
github · May 31, 2024 · 257f0eb · 257f0eb
1 parent 534ce30
commit 257f0eb
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/src/relative-time-element.ts b/src/relative-time-element.ts
@@ -440,9 +440,9 @@ export class RelativeTimeElement extends HTMLElement implements Intl.DateTimeFor
       return
     }
     const now = Date.now()
-    if (!this.#customTitle && !this.noTitle) {
+    if (!this.#customTitle) {
       newTitle = this.#getFormattedTitle(date) || ''
-      if (newTitle) this.setAttribute('title', newTitle)
+      if (newTitle && !this.noTitle) this.setAttribute('title', newTitle)
     }
 
     const duration = elapsedTime(date, this.precision, now)