Try to fix flaky GC test

assert_not_nil could allocate objects which may trigger the major GC, so don't run the assertions until the major GC has been ran.
github · Oct 30, 2023 · eac197c · eac197c
1 parent cdb85d2
commit eac197c
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/test/ruby/test_gc.rb b/test/ruby/test_gc.rb
@@ -261,9 +261,12 @@ def test_latest_gc_info_need_major_by
       objects.append(100.times.map { '*' })
     end
 
-    assert_not_nil GC.latest_gc_info(:need_major_by)
+    need_major_by = GC.latest_gc_info(:need_major_by)
     GC.start(full_mark: false) # should be upgraded to major
-    assert_not_nil GC.latest_gc_info(:major_by)
+    major_by = GC.latest_gc_info(:major_by)
+
+    assert_not_nil(need_major_by)
+    assert_not_nil(major_by)
   end
 
   def test_stress_compile_send