Same repository that is part of multiple suborgs #664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@decyjphr Hi Yadhav.. Looks like this is still in draft. Is it ready to get submitted to merge? |
|
@thebollywoodguy I am still working on it. Right now, the issue is if settings.yml or repos/repo.yml is modified, we load all the suborg configs and so we can determine if a repo has multiple suborg configs, but if a single ../suborgs/.yml is modified, we only load that suborg config (for efficiency) and so we cannot determine if the repos for it is also present in other suborg-configs. |
|
@thebollywoodguy this PR is now code complete. |
|
@thebollywoodguy I created a release |
|
Let me inform the customer. Thank you so much Yadhav |
Gramatus
added a commit
to Gramatus/safe-settings
that referenced
this pull request
Oct 6, 2024
torgst
pushed a commit
to helse-sorost/safe-settings
that referenced
this pull request
Oct 6, 2024
Mostly, the changes in github#664 relaxes the eslint rules, but that PR also removes the space before the parentheses in function definitions. The formatting was done with the vscode js/ts formatter `vscode.typescript-language-features`, and since this also does the same change it is now consistent across the whole codebase. Other than removing the space-before-function-paren, some files with inconsistent indentation and/or trailing spaces has been updated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added code for the following items: