Fix support for uppercase environment variables #717
+594
−268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI @decyjphr @luvsaxena1 , another couple fixes for environment variables. |
klutchell
force-pushed
the
kyle/uppercase-env-vars
branch
from
2b1f9f7 to
523dd73
Compare
Signed-off-by: Kyle Harding <[email protected]>
Signed-off-by: Kyle Harding <[email protected]>
This boolean was reversed when filtering existing variables, so it consistently sent a POST request to existing vars. Signed-off-by: Kyle Harding <[email protected]>
klutchell
force-pushed
the
kyle/uppercase-env-vars
branch
from
523dd73 to
dce0116
Compare
The current behaviour was to force all variable names to lowercase which was resulting in the wrong behaviour on POST. Instead, just force lowercase when comparing with existing variables. Signed-off-by: Kyle Harding <[email protected]>
klutchell
force-pushed
the
kyle/uppercase-env-vars
branch
2 times, most recently
from
5df3314 to
d46d969
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Github REST API supports case-sensitive names on this endpoint
so we should always create (POST) variables with the desired case.
On subsequent GET, PATCH, and DELETE requests the Github REST API
will use loose matching to find any existing objects, ignoring case.
So in general we need to force to lowercase to perform diffs, and respect
the provided case for create, but for all other calls it doesn't matter
which case is used.