Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always use public API #104

Merged
merged 2 commits into from
Jun 14, 2024
Merged

Always use public API #104

merged 2 commits into from
Jun 14, 2024

Conversation

mustard-mh
Copy link
Contributor

@mustard-mh mustard-mh commented Jun 13, 2024

Description

Related Issue(s)

Fixes [internal doc], ENT-295

How to test

It can open and connect workspaces in Gitpod

Local SSH SSH Gateway
image image

Documentation

/hold

@mustard-mh mustard-mh requested a review from jeanp413 June 14, 2024 06:50
@mustard-mh mustard-mh marked this pull request as ready for review June 14, 2024 06:50
@mustard-mh
Copy link
Contributor Author

@jeanp413 could you have a look? test results have posted in PR description

Copy link
Member

@geropl geropl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM. Did not test again. ✔️

@mustard-mh mustard-mh merged commit 22c39f2 into master Jun 14, 2024
1 check passed
@jeanp413 jeanp413 deleted the hw/ff-3 branch June 15, 2024 14:58
@jeanp413
Copy link
Member

Cool Finally 🎉

But you missed to update

async function getUserInfo(token: string, serviceUrl: string, logger: ILogService) {
const user = await withServerApi(token, serviceUrl, service => service.server.getLoggedInUser(), logger);
return {
id: user.id,
accountName: user.name ?? user.fullName ?? '<unknown>'
};
}
and also delete internalApi.ts 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants