Skip to content
This repository has been archived by the owner on Feb 25, 2022. It is now read-only.

Create new dumper and first iteration on replaceing payees #55

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

spruce
Copy link

@spruce spruce commented Mar 22, 2019

Hi,
first of all thanks for the project. Was a great help with getting started with the new ynab.

I have created a new dumper which handles some of the strange edge cases of my current bank.
Also took the first stab at payee replacements.
If you have questions I'm happy to answer them. (I probably need to add some test)

@gitviola
Copy link
Owner

Hey @spruce! Thanks for this awesome PR!!

This is a really good idea. After some researching I found that YNAB actually has a way to do this directly on their side: https://docs.youneedabudget.com/article/611-payee-management

After reading the API documentation it should take those Payee rules into account:

payee_name
string
The payee name. If a payee_name value is provided and payee_id has a null value, the payee_name value will be used to resolve the payee by either (1) a matching payee rename rule (only if import_id is also specified) or (2) a payee with the same name or (3) creation of a new payee.

https://api.youneedabudget.com/v1#/Transactions/createTransaction
(if you click on Model in the data-section)

So I guess maybe we don't even need it here and you just need to create the Payee in your Budget and make a rule that NETFLIX INTERNATIONAL B.V. is an alternative name for Netflix. 😊

@gitviola gitviola added the Waiting for reporter input This ticket has been answered and is currently waiting for input from the reporter of the ticket. label Mar 22, 2019
@spruce
Copy link
Author

spruce commented Mar 25, 2019

Oh, I didn't know this. This would make this part of the PR obsolete. Should I create a new PR that only contains the additions not related to this?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Waiting for reporter input This ticket has been answered and is currently waiting for input from the reporter of the ticket.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants