feat: return early if req fails

Signed-off-by: Matt Gleich <[email protected]>
gleich · Jan 7, 2025 · ab319a9 · ab319a9
1 parent 96649cd
commit ab319a9
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 3 deletions.
diff --git a/internal/apis/applemusic/applemusic.go b/internal/apis/applemusic/applemusic.go
@@ -78,7 +78,9 @@ type cacheDataResponse struct {
 
 func serveHTTP(c *cache.Cache[cacheData]) http.HandlerFunc {
 	return http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
-		auth.IsAuthorized(w, r)
+		if !auth.IsAuthorized(w, r) {
+			return
+		}
 		w.Header().Set("Content-Type", "application/json")
 		c.DataMutex.RLock()
 

diff --git a/internal/apis/applemusic/playlists.go b/internal/apis/applemusic/playlists.go
@@ -96,7 +96,9 @@ func fetchPlaylist(id string) (playlist, error) {
 
 func playlistEndpoint(c *cache.Cache[cacheData]) http.HandlerFunc {
 	return http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
-		auth.IsAuthorized(w, r)
+		if !auth.IsAuthorized(w, r) {
+			return
+		}
 		id := chi.URLParam(r, "id")
 
 		c.DataMutex.RLock()

diff --git a/internal/cache/cache.go b/internal/cache/cache.go
@@ -42,7 +42,9 @@ type CacheResponse[T any] struct {
 
 func (c *Cache[T]) ServeHTTP() http.HandlerFunc {
 	return http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
-		auth.IsAuthorized(w, r)
+		if !auth.IsAuthorized(w, r) {
+			return
+		}
 		w.Header().Set("Content-Type", "application/json")
 		c.DataMutex.RLock()
 		err := json.NewEncoder(w).Encode(CacheResponse[T]{Data: c.Data, Updated: c.Updated})