feat: use method constants for requests

Signed-off-by: Matt Gleich <[email protected]>
gleich · Jan 7, 2025 · fb83f1a · fb83f1a
1 parent 7c13ac6
commit fb83f1a
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 5 deletions.
diff --git a/internal/apis/applemusic/api.go b/internal/apis/applemusic/api.go
@@ -14,7 +14,7 @@ import (
 func sendAppleMusicAPIRequest[T any](path string) (T, error) {
 	var zeroValue T
 	req, err := http.NewRequest(
-		"GET",
+		http.MethodGet,
 		fmt.Sprintf("https://api.music.apple.com/%s", strings.TrimLeft(path, "/")),
 		nil,
 	)

diff --git a/internal/apis/steam/achievements.go b/internal/apis/steam/achievements.go
@@ -106,7 +106,7 @@ func fetchGameAchievements(appID int32) (*float32, *[]achievement, error) {
 		"format": {"json"},
 	}
 	req, err := http.NewRequest(
-		"GET",
+		http.MethodGet,
 		"https://api.steampowered.com/ISteamUserStats/GetSchemaForGame/v2?"+params.Encode(),
 		nil,
 	)

diff --git a/internal/apis/steam/games.go b/internal/apis/steam/games.go
@@ -47,7 +47,7 @@ func fetchRecentlyPlayedGames() ([]game, error) {
 		"include_appinfo": {"true"},
 		"format":          {"json"},
 	}
-	req, err := http.NewRequest("GET",
+	req, err := http.NewRequest(http.MethodGet,
 		"https://api.steampowered.com/IPlayerService/GetOwnedGames/v1?"+params.Encode(), nil,
 	)
 	if err != nil {

diff --git a/internal/apis/strava/api.go b/internal/apis/strava/api.go
@@ -14,7 +14,7 @@ func sendStravaAPIRequest[T any](path string, tokens tokens) (T, error) {
 	var zeroValue T
 
 	req, err := http.NewRequest(
-		"GET",
+		http.MethodGet,
 		fmt.Sprintf("https://www.strava.com/%s", strings.TrimLeft(path, "/")),
 		nil,
 	)

diff --git a/internal/apis/strava/tokens.go b/internal/apis/strava/tokens.go
@@ -38,7 +38,11 @@ func (t *tokens) refreshIfNeeded() {
 		"refresh_token": {t.Refresh},
 		"code":          {secrets.SECRETS.StravaOAuthCode},
 	}
-	req, err := http.NewRequest("POST", "https://www.strava.com/oauth/token?"+params.Encode(), nil)
+	req, err := http.NewRequest(
+		http.MethodPost,
+		"https://www.strava.com/oauth/token?"+params.Encode(),
+		nil,
+	)
 	if err != nil {
 		lumber.Error(err, "creating request for new token failed")
 		return