Add the ability to set custom fonts for posts #1934
Conversation
miniBill
force-pushed
the
fonts
branch
4 times, most recently
from
472b064 to
4537ab2
Compare
| @@ -1,3 +1,7 @@ | |||
| - if @fonts.present? | |||
There was a problem hiding this comment.
Plausibly this should go in the layout file somewhere so we're not throwing style tags in the body of the document
| @@ -157,6 +157,13 @@ | |||
| t.index ["post_id"], name: "index_flat_posts_on_post_id" | |||
| end | |||
|
|
|||
| create_table "fonts", force: :cascade do |t| | |||
There was a problem hiding this comment.
Not sure why this didn't generate with an id: :serial? Do we need it?
| expect(Setting.count).to eq(2) | ||
| expect(ContentWarning.count).to eq(2) | ||
| expect(Label.count).to eq(2) | ||
| expect(Font.count).to eq(2) |
There was a problem hiding this comment.
I think you actually want to check PostFont.count is 0 here (to make sure it failed, rather than making sure the factory worked)
| expect(Setting.count).to eq(2) | ||
| expect(ContentWarning.count).to eq(2) | ||
| expect(Label.count).to eq(2) | ||
| expect(Font.count).to eq(2) |
| expect(Setting.count).to eq(3) | ||
| expect(ContentWarning.count).to eq(3) | ||
| expect(Label.count).to eq(3) | ||
| expect(Font.count).to eq(2) |
| belongs_to :post, inverse_of: :post_fonts, optional: false | ||
| belongs_to :font, inverse_of: :post_fonts, optional: false | ||
|
|
||
| validates :post, uniqueness: { scope: :font } |
There was a problem hiding this comment.
Unit test somewhere to ensure this?
| @@ -27,6 +27,9 @@ class Post < ApplicationRecord | |||
| has_many :content_warnings, -> { ordered_by_post_tag }, through: :post_tags, source: :content_warning, | |||
| after_add: :reset_warnings, dependent: :destroy | |||
|
|
|||
| has_many :post_fonts, dependent: :destroy | |||
| has_many :fonts, through: :post_fonts, dependent: :destroy | |||
There was a problem hiding this comment.
Add to a unit test somewhere ensuring this destroy happens? (to the PostFont and not the Font)
Co-authored-by: Marri <[email protected]>
Gladly, but I'd do it in a separate PR anyway |
Security considerations: the users must not be able to create or edit fonts. I'm not sure how to enforce that.