Add ActiveStorage #1952
Draft
Add ActiveStorage #1952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teceler
force-pushed
the
add/active-storage
branch
from
21c5f96 to
b25e275
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Marri
reviewed
Jan 21, 2024
|
|
||
| def perform(icon_id) | ||
| icon = Icon.find(icon_id) | ||
| raise IconNotUploaded, "Icon #{icon.id} is remotely hosted" unless icon.s3_key.present? |
There was a problem hiding this comment.
possibly for another PR but: do we want to do this for all icons? we've discussed eliminating remote hosting before, and if this does it anyway?
There was a problem hiding this comment.
I don't think this is reuploading them like we'd want for that, iirc it's just entering them in activestorage with their current urls.
teceler
force-pushed
the
add/active-storage
branch
from
b25e275 to
5e3c231
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.