Add multi-reply feature #2378
Open
Add multi-reply feature #2378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
redmvc
added
type: enhancement
design/ui
type: new feature
u. ready to review
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
Co-authored-by: Edward Jones <[email protected]>
This reverts commit 8e2b16a.
| # Posting a new multi reply, go back to unread | ||
| redirect_to post_path(params[:reply][:post_id], page: :unread, anchor: :unread) | ||
| end | ||
| return |
There was a problem hiding this comment.
Avoid too many return statements within this method.
There was a problem hiding this comment.
I tried reducing them as much as I could but I don't think I can do better than what I currently have.
This comment was marked as resolved.
This comment was marked as resolved.
Throne3d
reviewed
Jan 4, 2025
Co-authored-by: Edward Jones <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
| return | ||
| elsif params[:button_discard_multi_reply] | ||
| flash[:success] = "Replies discarded." | ||
| if editing_multi_reply? |
There was a problem hiding this comment.
Avoid deeply nested control flow statements.
There was a problem hiding this comment.
My brother in Christ if you have a better suggestion I am all ears
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature allows the user to post multiple replies all at once, or to edit an existing reply and turn it into multiple replies in-place (to, effectively, "split" it).