Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Featured plugins #65

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Featured plugins #65

wants to merge 1 commit into from

Conversation

orthagh
Copy link
Contributor

@orthagh orthagh commented Feb 11, 2020

SQL request required to adapt existing DB: ALTER TABLE `plugin` ADD `featured` int NULL AFTER `active`;

@orthagh orthagh requested a review from cedric-anne February 11, 2020 15:45
@orthagh orthagh changed the title Feature/featured Featured plugins Feb 11, 2020
@orthagh
Copy link
Contributor Author

orthagh commented Feb 12, 2020

I just added a commit to change how sub plugin endpoints (trending, new, etc) retrieve partial data.
Previously it was an hard limit set on 10, now it's paginated with X-range header (if not set, default is 15 items returned).

For marketplace, it could serve to do some sorting (by download count, new, updated, etc).

api/src/endpoints/Plugin.php Show resolved Hide resolved
misc/structure.sql Outdated Show resolved Hide resolved
@cedric-anne
Copy link
Member

This PR is technically OK.

Is the feature still wanted ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants