Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Utf8 fixes #190

Closed
wants to merge 0 commits into from
Closed

Utf8 fixes #190

wants to merge 0 commits into from

Conversation

markeel
Copy link
Contributor

@markeel markeel commented May 25, 2023

This changes the encoding of any string from libgit2 to be treated as UTF-8. The only down side of this fix is if someone was already using something like ASCII-8BIT, but that seems less likely than someone using UTF-8 but with characters that are multi-byte.

@markeel
Copy link
Contributor Author

markeel commented Mar 29, 2024

I submitted a pull request a year ago, and it still has to be reviewed. I basically forgot about it (and have been using my version of this plugin since then), How do we move this along?

@Calinou
Copy link
Member

Calinou commented Mar 30, 2024

I submitted a pull request a year ago, and it still has to be reviewed. I basically forgot about it (and have been using my version of this plugin since then), How do we move this along?

Please rebase this against the latest master branch so this can be merged 🙂

See Pull request workflow for instructions.

.gitmodules Outdated
@@ -5,6 +5,7 @@
[submodule "libgit2"]
path = thirdparty/git2/libgit2
url = https://github.com/libgit2/libgit2
ignore = untracked
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of curiosity, why is this change needed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was a year ago, I think adding that stopped git from telling me there were changes in the libgit2. When I rebase against the latest master, I'll see if it was really necessary or just an artifact of me trying to figure out the problem.

@markeel markeel closed this Apr 1, 2024
@markeel markeel deleted the utf8_fixes branch April 1, 2024 19:39
@Calinou
Copy link
Member

Calinou commented Apr 1, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot show Chinese correctly
2 participants