feat: improve logic in the starbook #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gqcn
requested changes
Dec 23, 2024
|
|
||
| import ( | ||
| "star/api/users" | ||
| usersL "star/internal/logic/users" |
There was a problem hiding this comment.
在API中，接口包名应该是v1/v2这样的形式，而在logic中，应该是users这样的形式，因此并不需要设置别名。
There was a problem hiding this comment.
users被"star/api/users"占用了，那个是gen ctrl生成的
|
|
||
| func NewV1() users.IUsersV1 { | ||
| return &ControllerV1{ | ||
| users: &usersL.Users{}, |
There was a problem hiding this comment.
最好通过New的创建方法来初始化业务逻辑封装对象，因为外部调用时并不知道一个逻辑对象需要做什么初始化逻辑。直接使用&usersL.Users{}的方式就无法进行初始化逻辑封装了。
| func NewV1() words.IWordsV1 { | ||
| return &ControllerV1{ | ||
| users: &usersL.Users{}, | ||
| words: &wordsL.Words{}, |
| @@ -56,13 +56,13 @@ import ( | |||
| "star/utility" | |||
| ) | |||
|
|
|||
| type UserClaims struct { | |||
| type userClaims struct { | |||
There was a problem hiding this comment.
这个结构体users内部用的，想着也没必要公开
gqcn
approved these changes
Jan 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.