[StatementSwitchToExpressionSwitch] Combine immediately-preceding variable definitions with assignment switches to the same variable, where feasible #4730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
Stephan202
reviewed
Dec 17, 2024
| assignmentSwitchAnalysisState.assignmentTargetOptional(), | ||
| variableTreeOptional.get()); | ||
|
|
||
| System.out.println("XXX compatibleVariableDeclaration: " + compatibleVariableDeclaration); |
There was a problem hiding this comment.
Likely to also be caught by Google-internal code review, but: I assume these stdout print statements are meant to be dropped before the PR is merged 👀
Comment on lines
913
to
919
| if (precedingStatements.get(precedingStatements.size() - 1) instanceof VariableTree | ||
| && precedingStatements.get(precedingStatements.size() - 2) instanceof VariableTree) { | ||
|
|
||
| VariableTree variableTree1 = | ||
| (VariableTree) precedingStatements.get(precedingStatements.size() - 1); | ||
| VariableTree variableTree2 = | ||
| (VariableTree) precedingStatements.get(precedingStatements.size() - 2); |
There was a problem hiding this comment.
Suggested change
| if (precedingStatements.get(precedingStatements.size() - 1) instanceof VariableTree | |
| && precedingStatements.get(precedingStatements.size() - 2) instanceof VariableTree) { | |
| VariableTree variableTree1 = | |
| (VariableTree) precedingStatements.get(precedingStatements.size() - 1); | |
| VariableTree variableTree2 = | |
| (VariableTree) precedingStatements.get(precedingStatements.size() - 2); | |
| if (precedingStatements.get(precedingStatements.size() - 1) instanceof VariableTree variableTree1 | |
| && precedingStatements.get(precedingStatements.size() - 2) instanceof VariableTree variableTree2) { |
(A similar simplification is possible below.)
copybara-service
bot
force-pushed
the
test_705971103
branch
8 times, most recently
from
9351dd6 to
4006d62
Compare
copybara-service
bot
changed the title
copybara-service
bot
force-pushed
the
test_705971103
branch
17 times, most recently
from
90071a9 to
6bb99a7
Compare
copybara-service
bot
changed the title
…iable definitions with assignment switches to the same variable, where feasible PiperOrigin-RevId: 705971103
copybara-service
bot
force-pushed
the
test_705971103
branch
from
6bb99a7 to
afe0fbb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[StatementSwitchToExpressionSwitch] Combine immediately-preceding variable definitions with assignment switches to the same variable, where feasible