Add flag to disable container spec validation when restoring checkpoints #11323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please move the word "unsafe" to beginning of the flag/variable name ( |
|
Thanks, done! |
cweld510
force-pushed
the
cweld/skip-spec-validation-unsafe
branch
from
c9dc733 to
8cfb7df
Compare
EtiennePerot
requested changes
Dec 28, 2024
runsc/boot/restore.go
Outdated
| @@ -132,7 +132,7 @@ func (r *restorer) restoreContainerInfo(l *Loader, info *containerInfo) error { | |||
|
|
|||
| if len(r.containers) == r.totalContainers { | |||
| // Trigger the restore if this is the last container. | |||
| return r.restore(l) | |||
| return r.restore(l, info.conf.SkipRestoreSpecValidationUnsafe) | |||
There was a problem hiding this comment.
Still need to update this one.
There was a problem hiding this comment.
Fixed; really sorry about that.
cweld510
force-pushed
the
cweld/skip-spec-validation-unsafe
branch
from
8cfb7df to
17b2c1b
Compare
EtiennePerot
approved these changes
Dec 30, 2024
copybara-service bot
pushed a commit
that referenced
this pull request
Dec 30, 2024
This PR adds a new flag entitled `skip-restore-spec-validation-unsafe`, defaulting to false. If the flag is set, the container spec given when restoring a checkpoint will no longer be validated against the original container spec given when the checkpoint was taken. In practice, many spec differences are benign, and it can be useful to allow the container specs to vary somewhat between checkpoint and restore. See #11307 . FUTURE_COPYBARA_INTEGRATE_REVIEW=#11323 from cweld510:cweld/skip-spec-validation-unsafe 17b2c1b PiperOrigin-RevId: 710752422
copybara-service bot
pushed a commit
that referenced
this pull request
Dec 30, 2024
This PR adds a new flag entitled `skip-restore-spec-validation-unsafe`, defaulting to false. If the flag is set, the container spec given when restoring a checkpoint will no longer be validated against the original container spec given when the checkpoint was taken. In practice, many spec differences are benign, and it can be useful to allow the container specs to vary somewhat between checkpoint and restore. See #11307 . FUTURE_COPYBARA_INTEGRATE_REVIEW=#11323 from cweld510:cweld/skip-spec-validation-unsafe 17b2c1b PiperOrigin-RevId: 710752422
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new flag entitled
skip-restore-spec-validation-unsafe, defaulting to false. If the flag is set, the container spec given when restoring a checkpoint will no longer be validated against the original container spec given when the checkpoint was taken. In practice, many spec differences are benign, and it can be useful to allow the container specs to vary somewhat between checkpoint and restore. See #11307 .