Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update template generator for DialectTransforms #1222

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

update template generator for DialectTransforms #1222

wants to merge 1 commit into from

Conversation

ZenithalHourlyRate
Copy link
Collaborator

Similar to #1215

@WoutLegiest WoutLegiest self-requested a review December 23, 2024 22:27
WoutLegiest
WoutLegiest approved these changes Dec 23, 2024
View reviewed changes
Copy link
Collaborator

@WoutLegiest WoutLegiest left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM (Also tested it in the meantime)

@j2kun j2kun added the pull_ready Indicates whether a PR is ready to pull. The copybara worker will import for internal testing label Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexanderViand-Intel AlexanderViand-Intel AlexanderViand-Intel approved these changes

@WoutLegiest WoutLegiest WoutLegiest approved these changes

@j2kun j2kun j2kun approved these changes

Assignees
No one assigned
Labels
pull_ready Indicates whether a PR is ready to pull. The copybara worker will import for internal testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ZenithalHourlyRate @j2kun @WoutLegiest @AlexanderViand-Intel