Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement readonly tag for primary and attr #107

Open
wants to merge 1 commit into
base: feature/embeded-structs
Choose a base branch
from

Conversation

jrdnull
Copy link

@jrdnull jrdnull commented Aug 1, 2017

If the readonly tag is present the field will be skipped when using the
Unmarshal methods.
Resolves #102

Opened against and based off of the feature/embeded-structs branch to avoid conflicts, can re-open against master once that is merged, just wanted to get this discussed/reviewed to see if this is something the project is interested in supporting.

The main use case for this is to easily support PATCH requests without resorting to pointers in my models or copying and resetting values.

If the readonly tag is present the field will be skipped when using the
Unmarshal methods.
Resolves google#102
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

@jrdnull
Copy link
Author

jrdnull commented Aug 1, 2017

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@3bb
Copy link

3bb commented Feb 16, 2019

Any update ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants