Fix masking with more than one input feature #158
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where passing inputs
x1
andx2
of dimension(..., n_feat)
withn_feat > 1
to akernel_fn
generates masks in the Kernel which still carry the original feature dimension.This creates a problem for layers such as
GlobalAvgPool
, since for kernels that represent infinitely wide layers it is generally assumed that the channel dimension is one.I implemented a reduction over the mask's last dimension using
np.any(.., keepdims=True)
, which assumes that it doesn't matter if any or all of the features are masked. A user warning spells this out.I can create an issue with a reproducer shortly, if more detail is needed. Can also add a unit test.