Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make batch capable of emulating cloud build #12833

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

jonathanmetzman
Copy link
Contributor

No description provided.

@@ -0,0 +1,49 @@
#!/usr/bin/env python3
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we look at using https://github.com/GoogleCloudPlatform/cloud-build-local instead? It's unmaintained, but it should at least be closer to real cloud build than anything we write.

There's probably specifics here that we're missing (e.g. the "cloudbuild" network) which might subtly break things otherwise.

Copy link
Contributor Author

@jonathanmetzman jonathanmetzman Dec 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we look at using https://github.com/GoogleCloudPlatform/cloud-build-local instead? It's unmaintained, but it should at least be closer to real cloud build than anything we write.

It completely failed on everything I tried it on. But I could be holding it wrong, maybe someone else should try it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with you that it's a better solution in theory. This was a last resort after realizing there was no other option that could give us builds with VM level isolation.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What did we need the VM level isolation for btw? Is this for OSS-Fuzz-Gen?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For OSS-Fuzz as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants